OpenPilot

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ok. No problem. The wizard is modal so the high update rate is not really empeding with anything.

Ok. No problem. The wizard is modal so the high update rate is not really empeding with anything.

I also tested w/ D4R-II .. looks good

I also tested w/ D4R-II .. looks good

I was hoping to bring it back later in the future and don't want to change the UAVO twice. But I wasn't really sure if it's agood idea to handle it this way. I guess you are right, I'll change this.

I was hoping to bring it back later in the future and don't want to change the UAVO twice. But I wasn't really sure if it's agood idea to handle it this way. I guess you are right, I'll change this.

we could disable it, but then I'd remove the kI parameter from the UAVObject too, otherwise people will set stuff and wonder why its not working, and then they'd forget that they did set it and cra...

we could disable it, but then I'd remove the kI parameter from the UAVObject too, otherwise people will set stuff and wonder why its not working, and then they'd forget that they did set it and crash when it does work again all of a sudden

Thanks! http://reviews.openpilot.org/static/nayw5f/2static/images/wiki/icons/emoticons/smile.gif

Thanks!

Does anyone want to do further reviews or test this before integrating this change? I've tested the code with FrySky D4R-II in PPM mode and X6R in S.bus mode.

Does anyone want to do further reviews or test this before integrating this change?

I've tested the code with FrySky D4R-II in PPM mode and X6R in S.bus mode.

wouldn't it be better/cleaner to provide always failing stubs for PIOS_FlashFS_* from lower level PIOS instead of having this #ifdef casing in the uavobjectmanager?

wouldn't it be better/cleaner to provide always failing stubs for PIOS_FlashFS_* from lower level PIOS instead of having this #ifdef casing in the uavobjectmanager?

After thinking about this more, I don't think the old code is better or safer. I don't see any significant drawback of turning up the rates at the beginning of the wizard and then reverting them wh...

After thinking about this more, I don't think the old code is better or safer. I don't see any significant drawback of turning up the rates at the beginning of the wizard and then reverting them when the wizard is exited. There's just a few pages at the beginning of the wizard that used to use slow rates, that now will use higher rates. I can't see why that would be a problem. If it is a problem then the entire idea to increase the rates on the other pages are flawed IMHO.

With that said, my opinion is that we don't have to rollback that change and we don't need a comment in the code stating that we should roll it back. If we really should roll it back, I think it's more appropriate to open a new Jira case.

OP-1222 Added ground shapes : Motorbike, Tank and Car

    • -0
    • +2579
    /ground/openpilotgcs/src/plugins/config/images/ground-shapes.svg
Merge remote-tracking branch 'origin/hayvosh/OP-1489_ILimits' into next

comment typeo

OP-1476 - Makefile fixes from review

Old bug, buttongroup clash
Old bug, buttongroup clash
That's really an awesome work and will certainly make a lot of mini copter owners happy http://reviews.openpilot.org/static/nayw5f/2static/images/wiki/icons/emoticons/smile.gif

That's really an awesome work and will certainly make a lot of mini copter owners happy

That would be the debug config for help http://reviews.openpilot.org/static/nayw5f/2static/images/wiki/icons/emoticons/smile.gif

That would be the debug config for help

Old bug, buttongroup clash

Uplimits

Merge remote-tracking branch 'origin/next' into hayvosh/OP-1489_ILimits

OSX Qt5.3.2 changes to tools.mk

Should be "Uploader Tool". Why is it that the closer to the hardware we get the more uppercase letter there are? http://reviews.openpilot.org/static/nayw5f/2static/images/wiki/icons/emoticons/wink.gif

Should be "Uploader Tool".
Why is it that the closer to the hardware we get the more uppercase letter there are?